On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham
<chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:
> Make use of struct gpio_desc which allows us to specify the active state
> of the reset pin.
> + if (gpio_is_valid(platform_data->gpio)) {
No way, it should be provided by GPIO lookup table.
> + ret = devm_gpio_request_one(&pdev->dev,
> + platform_data->gpio,
> + GPIOF_ACTIVE_LOW,
> + i2c->adap.name);
> + if (ret == 0) {
> + i2c->gpio = gpio_to_desc(platform_data->gpio);
This has to be devm_gpiod_get() instead.
Wolfram, I suggested to drop the series for now and wait for improvements.
--
With Best Regards,
Andy Shevchenko
