Hi, On 14-12-16 15:41, Chen-Yu Tsai wrote:
On Wed, Dec 14, 2016 at 9:52 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:The axp288 pmic has a lot more volatile registers then we were listing in axp288_volatile_ranges, fix this. Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> --- drivers/mfd/axp20x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index a294121..b9c1adf 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -117,7 +117,10 @@ static const struct regmap_range axp288_writeable_ranges[] = { }; static const struct regmap_range axp288_volatile_ranges[] = { + regmap_reg_range(AXP20X_PWR_INPUT_STATUS, AXP20X_PWR_OP_MODE),Actually register 0x02 is volatile as well. Various fields say "write 1 to clear". You might need a new define for it though, as the usage is different.regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IPSOUT_V_HIGH_L), + regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE), + regmap_reg_range(AXP20X_FG_RES, AXP288_FG_CC_CAP_REG),Could you also add AXP20X_TIMER_CTRL and 0xa0 ~ 0xa1 (real time battery voltage), if you're adding defines?
We also need to add 0xbc "BC Detect Status Register" to be able to get the results of the charger detect logic in the axp288. Self-nak for v2, I will send a v3 later. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
