On Wed, Dec 14, 2016 at 9:52 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > The interrupt line of the entire family of axp2xx pmics is active-low, > for devicetree enumerated irqs, this is dealt with in the devicetree. > > ACPI irq resources have a flag field for this too, I tried using this > on my CUBE iwork8 Air tablet, but it does not contain the right data. > > The dstd shows the irq listed as either ActiveLow or ActiveHigh, > depending on the OSID variable, which seems to be set by the > "OS IMAGE ID" in the BIOS/EFI setup screen. > > Since the acpi-resource info is no good, simply pass in IRQF_TRIGGER_LOW > on the axp288. > > Together with the other axp288 fixes in this series, this fixes the axp288 > irq contineously triggering. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> This patch looks good to me. However, I do not have any AXP288 hardware to test it on, nor am I familiar with the ACPI stuff. Acked-by: Chen-Yu Tsai <wens@xxxxxxxx> P.S. I don't think we're handling IRQ trigger types at all. The hardware default for the NMI interrupt in the Allwinner chips just happens to be active low. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
