2015-05-05 2:52 GMT+09:00 Vasily Khoruzhick <anarsoul@xxxxxxxxx>: > On Mon, May 4, 2015 at 2:50 AM, Krzysztof Kozlowski > <k.kozlowski@xxxxxxxxxxx> wrote: >> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul@xxxxxxxxx>: >>> Initialize sysreg by default, otherwise driver will crash in suspend callback. >>> >>> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> >> >> I think the crash is possible if device node is missing in DT or pdata >> is supplied. > > And it's exactly the case for non-DT boot, right? Right, please add this to commit message. > >> If you agree, could you add this information to commit >> message, along with Cc-stable and Fixes tag? > > How do I add "Fixes tag"? In tbe commit message just add below Signed-off-by: 1. Cc: <stable@xxxxxxxxxxxxxxx> 2. Fixes: abbreviated SHA ("commit subject") The SHA of commit which introduced this error. It indicates how far your patch should be backported. Look for examples in kernel GIT and Documentation/stable_kernel_rules.txt. For example: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1c363c7cccf64128087002b0779986ad16aff6dc Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html