Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul@xxxxxxxxx>:
> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>

I think the crash is possible if device node is missing in DT or pdata
is supplied. If you agree, could you add this information to commit
message, along with Cc-stable and Fixes tag?

Anyway, the patch itself looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux