Re: [PATCH 0/3] i2c: davinci: Fix problems discovered on Keystone CPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 12, 2015 at 08:52:39AM +0100, Alexander Sverdlin wrote:
> Hi!
> 
> On 11/03/15 19:35, ext Grygorii.Strashko@xxxxxxxxxx wrote:
> >> The series address the follwing problems:
> >> > "i2c: davinci: Rework racy ISR" -- stop the parallel activities in the driver
> >> > including concurrect registers access. Also simplifies the design and removes
> >> > some bad aids.
> >> > "i2c: davinci: Refactor i2c_davinci_wait_bus_not_busy()" -- the routine is
> >> > over-designed and instead of "waiting" will trigger the bus recovering
> >> > immediately.
> >> > "i2c: davinci: Avoid sending to own address" -- works around one davinci
> >> > controller issue when it unexpectedly switches to some sort of slave mode
> >> > trying to send to its own address. The controller remains in this locked state
> >> > until reset, so it's better to avoid this situation than to deal with transfer
> >> > timeouts.
> >> > 
> > 
> > Have you used git format-patch --cover-letter?
> > Overall stats and list of patches are missing.
> 
> Will do in v2...

And please make sure the patches are chained to the cover-letter. That
makes reviewing much easier.

> First patch is an important fix for blocking problem and therefore a candidate for
> -stable backports. So, it should be less dependent of the less-important 2 and 3.

IMO this patch is too intrusive for stable, so I won't add the tag. You
may request that individually to stable maintainers, though, if you
disagree.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux