Re: [PATCH 0/3] i2c: davinci: Fix problems discovered on Keystone CPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/11/2015 03:08 PM, Alexander Sverdlin wrote:
> During intensive I2C tests on Keystone CPU we've discovered several problems
> with the i2c-davinci driver. Maybe Keystone is the first relatively powerful CPU
> utilizing davinci controller and therefore the races in the driver became more
> obvious, but it's clear that many users had problems with the driver and even
> though driver has received many band aids over the years, nobody addressed the
> original racy design.
> 
> The series address the follwing problems:
> "i2c: davinci: Rework racy ISR" -- stop the parallel activities in the driver
> including concurrect registers access. Also simplifies the design and removes
> some bad aids.
> "i2c: davinci: Refactor i2c_davinci_wait_bus_not_busy()" -- the routine is
> over-designed and instead of "waiting" will trigger the bus recovering
> immediately.
> "i2c: davinci: Avoid sending to own address" -- works around one davinci
> controller issue when it unexpectedly switches to some sort of slave mode
> trying to send to its own address. The controller remains in this locked state
> until reset, so it's better to avoid this situation than to deal with transfer
> timeouts.
> 


Have you used git format-patch --cover-letter?
Overall stats and list of patches are missing.

Also I think It'll be better to send patches 2/3 first, as
they have more chances to be merged. 

regards,
-grygorii

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux