This patch fixes the following sparse warning in drivers/i2c/: CHECK drivers/i2c/i2c-core.c drivers/i2c/i2c-core.c:2353:36: warning: dubious: x | !y Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@xxxxxxxxx> --- drivers/i2c/i2c-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index edf274c..f50d46e 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -2350,7 +2350,7 @@ static u8 i2c_smbus_pec(u8 crc, u8 *p, size_t count) static u8 i2c_smbus_msg_pec(u8 pec, struct i2c_msg *msg) { /* The address will be sent first */ - u8 addr = (msg->addr << 1) | !!(msg->flags & I2C_M_RD); + u8 addr = (msg->addr << 1) | ((msg->flags & I2C_M_RD) != 0); pec = i2c_smbus_pec(pec, &addr, 1); /* The data buffer follows */ -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html