On 2014年09月18日 23:10, Wolfram Sang wrote: > On Thu, Sep 18, 2014 at 03:58:57PM +0300, Mika Westerberg wrote: >> On Thu, Sep 18, 2014 at 02:17:58PM +0200, Jean Delvare wrote: >>> Hi guys, >>> >>> Sorry for jumping in a bit late, but given that I did not get involved >>> in the discussions that led to this decision, better late than never. >>> >>> I almost had an heart attack when noticing that module i2c-core.ko has >>> suddenly been renamed to i2ccore.ko without an hyphen. >>> >>> Renaming kernel modules is almost always wrong, in particular subsystem >>> core modules. Such renames have an impact at various levels. We just had >>> to change a configuration file in the openSUSE Factory kernel to adjust >>> that change, and this is how I noticed it. But there can be several >>> other issues, including mkinitrd or equivalent tools, as well as >>> documentation. The extra work and confusion is a high price to pay, and >>> it can easily be avoided. >> >> I understand completely your point and I guess this was rather >> inadvertent change. > > Yes. Thanks for pointing out, Jean! > >> >>> So I am kindly asking that you revert this name change before kernel >>> v3.17 final. Rename source files if you really have to, git makes it >>> easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or >>> whatever. Just don't rename i2c-core.ko, please. >> >> My vote goes for merging i2c-acpi.c back to i2c-core.c with #ifdefs. >> >> Tianyu, Wolfram, comments? > > Agreed. > How about including i2c-acpi.c in the i2c-core.c directly if ACPI is selected? -- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
