Addy, On Fri, Aug 22, 2014 at 11:47 AM, addy ke <addy.ke@xxxxxxxxxxxxxx> wrote: >> Addy, >> >> On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke <addy.ke@xxxxxxxxxxxxxx> wrote: >>> In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data >>> in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx >>> must be less than or equal 32 bytes at a time. >>> >>> Tested on rk3288-pinky board, elan receive 158 bytes data. >>> >>> Suggested-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> >> >> You only need a "Suggested-by" if the entire patch was suggested by >> someone. If someone provides you review feedback you don't need it. >> >> Said another way: in this case Dmitry didn't suggest that you need to >> fix the i2c controller to transmit 32 byte chunks (he only provided >> review feedback), so you shouldn't say this was Suggested-by him. >> >> You also had my reviewed-by on a previous version so you could keep it. >> >> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx> > > so, Do I need repost this patch or post a new one as patch v5? Tags are typically something that the maintainer (Wolfram) can adjust when he adds his own. I think it's OK and he can remove the "Suggested-by". However, if Wolfram responds and asks you to respin then you should follow his advice. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
