On Wed, 20 Aug 2014, Javier Martinez Canillas wrote: > From: Doug Anderson <dianders@xxxxxxxxxxxx> > > If someone sends a EC_CMD_REBOOT_EC to the EC, the EC will likely be > unresponsive for quite a while. Add a delay to the end of the command > to prevent random failures of future commands. > > NOTES: > * This could be optimized a bit by simply delaying the next command > sent, but EC_CMD_REBOOT_EC is such a rare command that the extra > complexity doesn't seem worth it. > * This is a bit of an "ugly hack" since the SPI driver is effectively > snooping on the communication and making a lot of assumptions. It > would be nice to architect in some better solution long term. Are you planning on doing that? > * This same logic probably needs to be applied to the i2c driver. > > Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx> > Reviewed-by: Randall Spangler <rspangler@xxxxxxxxxxxx> > Reviewed-by: Vadim Bendebury <vbendeb@xxxxxxxxxxxx> > Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > --- > drivers/mfd/cros_ec_spi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) I'm willing to accept this as a stand-in. Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
