Hi Wolfram, On Wed, Mar 05, 2014 at 05:34:30PM +0100, Wolfram Sang wrote: > On Tue, Mar 04, 2014 at 05:28:38PM +0100, Maxime Ripard wrote: > > The Allwinner A31 I2C controller is almost identical to the one used in the > > other Allwinner SoCs, except for the fact that it needs to clear the interrupt > > by setting the INT_FLAGS bit in the control register, instead of clearing it. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> > > Tested-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> > > Applied to for-next, thanks! > > Still... > > > + if (of_device_is_compatible(np, "allwinner,sun6i-a31-i2c")) > > + drv_data->irq_clear_inverted = true; > > ... next time an errata is needed, I think it makes sense to refactor all > these checks into one struct which can be used as match->data directly. Yep, it makes sense. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
