Hi Russell, On Fri, Mar 07, 2014 at 09:52:23AM +0000, Russell King - ARM Linux wrote: > On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: > > The Allwinner A31 SoC using that IP has a reset controller maintaining > > it reset unless told otherwise. > > > > Add some optional reset support to the driver. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> > > Tested-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> > > This appears to be causing some build errors in Olof's next builder > for many of the ARM platforms which make use of this: > > drivers/i2c/busses/i2c-mv64xxx.c:924: undefined reference to `reset_control_assert' > drivers/i2c/busses/i2c-mv64xxx.c:904: undefined reference to `reset_control_assert' > drivers/i2c/busses/i2c-mv64xxx.c:771: undefined reference to `devm_reset_control_get' > drivers/i2c/busses/i2c-mv64xxx.c:778: undefined reference to `reset_control_deassert' The reset framework doesn't define its functions when its not selected, and somehow I think it was not here. What's odd is that there is an explicit select on RESET_CONTROLLER in the Kconfig. Maybe it's the circular dependency issue that has been reported that cause this and Wolfram sent a patch for: http://patchwork.ozlabs.org/patch/327573/ Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
