Re: [PATCH V2 07/13] i2c: pnx: Use devm_*() functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> Which thing do I have to remove additionally?

Just have a close look at your patches and what you removed. You'll
figure. Hint: It is related to the resource.

> You mean the following?
> 
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res) {
> 	dev_err(&pdev->dev, "Unable to get mem resource.\n");

That's one thing, there is more.

> 
> I think that this error message is not necessary. So, I will
> remove it.

Yeah, just have a look at the actual implementation of
devm_ioremap_resource and you will *know* that it is not necessary.

> Please let me know additional things to be remove.

I believe in teaching fishing rather than giving fish.

Regards,

   Wolfram

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux