Re: [PATCH V2 07/13] i2c: pnx: Use devm_*() functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, January 10, 2014 6:24 AM, Wolfram Sang wrote:
> On Mon, Jan 06, 2014 at 11:39:29AM +0900, Jingoo Han wrote:
> > Use devm_*() functions to make cleanup paths simpler.
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > ---
> > Changes since V1:
> > - Use devm_ioremap_resource() to make the code simpler, per Wolfram Sang.
> 
> Yes, you used this function but you did not remove all the stuff which
> can go now since you use this function.

Hi Wolfram,

Which thing do I have to remove additionally?
You mean the following?

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
	dev_err(&pdev->dev, "Unable to get mem resource.\n");

I think that this error message is not necessary. So, I will
remove it. Please let me know additional things to be remove.
Thank you.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux