On Mon, Jan 06, 2014 at 12:12:16AM +0100, Sebastian Hesselbarth wrote: > On 01/06/2014 12:07 AM, Jason Gunthorpe wrote: > >On Sun, Jan 05, 2014 at 06:37:21PM +0100, Sebastian Hesselbarth wrote: > > > >>If you mean clock-gated with "powered down", the code is safe. It > >>enables the clock gate prior reading from the controller. Or is there > >>another way to power down the controller, so you cannot read from the > >>controller registers? > > > >There is a clock gate and a power down on kirkwood at least, Linux has > >no code for controlling the powerdown > > Does that power down really disable reading from PCIe controller > registers or is it just PHY power down? I haven't experimented with it, but every block that has a clock gate has a power down, so I doubt it is just a phy power down. > >In any event, I think processing a disabled DT node is not great.. > > Yeah, but you see another way to get the PCIe controller registers > instead? Or any other common id register to read? IMHO PCIe ids are > the best we can find here and Gregory found the first IP that really > depends on the SoC revision.. I don't know of another option off hand, unless something is encoded in the CPU ID register set. Encoding the IP block version in the I2C DT compatible string is the next best choice, but it obviously isn't automatic.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
