Re: [PATCH] i2c: i2c-gpio: fix issue when DT node greater than 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean Delvare,

On 10/15/2012 14:49, Jean Delvare wrote:
On Mon, 15 Oct 2012 10:59:19 +0800, Bo Shen wrote:
On 10/10/2012 10:54, Bo Shen wrote:
On 9/19/2012 23:54, Jean Delvare wrote:
On Wed, 19 Sep 2012 09:28:04 -0600, Stephen Warren wrote:
The problematic code appears to be:

snprintf(adap->name, sizeof(adap->name), "i2c-gpio%d", pdev->id);

Instead, I think that should be something more like:

adap->name = dev_name(&pdev->dev);

strlcpy(adap->name, dev_name(&pdev->dev), sizeof(adap->name))
  >> if anything, as adap->name is a buffer, not a pointer.

I am sorry for late. I have tested with DT, it works.

Please send this patch to fix the issue.
Thanks.

Ping?

Will you send this patch?

Which patch, please? On September 18th, you sent a first version.
Stephen Warren asked you for a change, but you never sent version two
of the patch including the requested change. So don't be surprised if
your patch never got applied.


I am sorry. I take a long vacation, so, I didnot send out version two.

Or, I send this patch and add your S.O.B, which do you prefer?

I prefer that you send patch v2 and let the interested parties review
and apply it. Do not add S-o-B for anyone else, ever.

OK. I will send out v2 as soon as possible.


Note that i2c-gpio is normally handled by Wolfram Sang, not me.

Thanks for your information.

BRs,
Bo Shen

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux