Hi Bo, Bo Shen wrote on Monday, October 15, 2012 4:10 AM: > Hi Joachim Eastwood, > > On 10/13/2012 1:42, Joachim Eastwood wrote: > > Hi Bo Shen, > > > > On Fri, Oct 12, 2012 at 11:42 AM, Bo Shen <voice.shen@xxxxxxxxx> wrote: > >> The i2c-gpio driver will turn the platform device ID to busnum. > >> When using platfrom device ID as -1, it means dynamically assigned > >> the busnum. When writing code, we need to make sure the busnum, > >> and call i2c_register_board_info(int busnum, ...) to register device > >> if using -1, we do not know the value of busnum. > >> > >> In order to solve this issue, set the platform device ID as a fix number > >> Here using 0 to match the busnum used in i2c_regsiter_board_info(). > > > > I have been bitten by this myself on RM9200. > > > >> Signed-off-by: Bo Shen <voice.shen@xxxxxxxxx> > >> --- > >> Change since v1 > >> Make the commit message more clear > >> --- > >> arch/arm/mach-at91/at91sam9260_devices.c | 2 +- > > > > This pattern exist in at91rm9200_devices.c, at91sam9261_devices.c, > > at91sam9263_devices.c and at91sam9rl_devices.c you might want to fix > > them as well. > > Thanks for your information. > After I test these boards, I will send patches to fix them, while not in > this patch. > > > > > I assume we have the same problem if CONFIG_I2C_AT91 is set? > > See further down in at91sam9260_devices.c we have another: ".id = -1," > > Maybe Nikolaus Voss will deal with this case. I merely tested with G45 SoC where .id is set to constants != -1. Could you extent your patch to cover the at91_i2c case, too? I think it would be good to have all these in one commit. Niko -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
