On Sat, Aug 18, 2012 at 6:52 PM, Shubhrajyoti Datta <omaplinuxkernel@xxxxxxxxx> wrote: > On Sat, Aug 18, 2012 at 3:47 PM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote: >> On Thu, Aug 09, 2012 at 07:07:43PM +0530, Shubhrajyoti D wrote: >>> platform_get_resource uses pdev so move the function >>> platform_set_drvdata(pdev, NULL) after the get_resource. >> > Yes agree. > >> This descriptions sounds as you'd assume pdev is set to NULL here? >> Careful, platform_set_drvdata() does not clear pdev, but driver_data of >> pdev->dev! >> >> So, I guess the rest of this series is bogus? >> >> It would be worth checking if other drivers have the same pattern as the >> omap driver where the fix was valid for other reasons. Are you >> interested in doing that (perfectly fine to say no). > > Yes I can take that , lest someone with the platform/ test set-up can > take that up. By the way davinci and designware seem to have the issue however having a closer look even the probe err handling looks wrong. >> >> Regards, >> >> Wolfram >> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
