Re: [PATCH 2/6] i2c-xiic: Fix a possible NULL pointer access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 18, 2012 at 3:47 PM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote:
> On Thu, Aug 09, 2012 at 07:07:43PM +0530, Shubhrajyoti D wrote:
>> platform_get_resource uses pdev so move the function
>> platform_set_drvdata(pdev, NULL) after the get_resource.
>
Yes agree.

> This descriptions sounds as you'd assume pdev is set to NULL here?
> Careful, platform_set_drvdata() does not clear pdev, but driver_data of
> pdev->dev!
>
> So, I guess the rest of this series is bogus?
>
> It would be worth checking if other drivers have the same pattern as the
> omap driver where the fix was valid for other reasons. Are you
> interested in doing that (perfectly fine to say no).

Yes I can take that , lest someone with the platform/ test set-up can
take that up.
>
> Regards,
>
>    Wolfram
>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux