On Tue, May 08, 2012 at 02:36:46PM +0000, Arnd Bergmann wrote: > Right, which is what the driver has done since 79568b9412 "regulator: > initialization for ab8500 regulators" with your ack, so we decided not > to change that and simply move the init data from platform code > to the device tree. Yes, I've never seen the arch/arm bit of it before to see what the magic writes actually do before - I did review the original code which just used the regulator API normally but not this magic number stuff which was just done in the platform. The magic numbers might be OK for things where it's device specific enough but the comments here make it clear that some of the magic number setup is duplicating framework features.
Attachment:
signature.asc
Description: Digital signature
