On Tuesday 08 May 2012, Mark Brown wrote: > On Tue, May 08, 2012 at 01:48:14PM +0000, Arnd Bergmann wrote: > > On Tuesday 08 May 2012, Lee Jones wrote: > > > > I did run this past Arnd before writing the code and he agreed that this > > > would be suitable; however, if you know of a better way in which I can > > > do this, I'd be pleased to hear of it. > > > It was the best approach that I could think of for this, but I'm also > > a total newbie on regulators. > > It's not really a regulator thing, what the code is doing is blasting in > a bunch of magic register writes to set things up, some of which are > configuring things that the subsystem already knows how to configure. Right, which is what the driver has done since 79568b9412 "regulator: initialization for ab8500 regulators" with your ack, so we decided not to change that and simply move the init data from platform code to the device tree. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html