Hello Jean, With the new patch the driver is working fine, also with i2c_debug = 3. See the screenshot in my dropbox (http://www.dropbox.com/gallery/16457261/1/I2C_2_MLX90614?h=8e2a46) >>> Jean Delvare <khali@xxxxxxxxxxxx> schrieb am Mittwoch, 15. Dezember 2010 um 15:42 in Nachricht <20101215154255.20d471a4@xxxxxxxxxxxxxxxx>: > Hallo Matthias, > > On Wed, 15 Dec 2010 13:46:26 +0100, Matthias Zacharias wrote: >> Thank you for the new patch. >> I tried it and it works fine for our system with i2c_debug < 2. > > Great, thanks for the feedback. > >> For i2c_debug >=2 the debug outputs leads to timeout condition when >> address should be acknowledged. > > Hmm, calling printk() with the spinlock held wasn't the smartest thing > to do, I guess. Updated patch attached, I've made sure to always > release the spinlock before calling bit_dbg(), hopefully it should fix > your last issue. > >> I'll try to publish the "mlx90614" driver after doing some >> optimizations. Are you interested to review this driver before, because >> it is the first driver we try to publish? > > Just publish it as is, and I'll review it publicly. It will certainly > take a number of round trips to get it right, if this is your first > contribution, but that's OK. > This MLX90614 driver has a reduced functionality. It was tailored for our application which use only the temperature read function. Also the SMBus address is fix defined in the source code, and no checkes if the factory preprogramming is correct are done. The option to manage the configuration of the MLX90614 as described in the datasheets is not yet implemented, because we don't need it. > FYI, I have asked Melexis for an MLX90614 evaluation board, they have > sent something to me, so as soon as I receive it I should be able to > test your driver. > The evalutionboard (EVB) shiped by Melexis uses his own microcontroller on that board and communicate to the PC via USB. In our system the MLX90614 sensor is connected directly to the port pins of the microcontroller. >> Do plan to include your patch on the "i2c-algo-bit" into the lastest >> kernel? > > Yes. Please test the new version of the patch, and if it works OK for > you, I'll schedule it for merge in kernel 2.6.38. For 2.6.37 it's too > late, the patch is quite intrusive and i2c-algo-bit is used by many > many drivers including very popular ones, so I can't merge it that late > in the release cycle. > >> I had applied the patch and done my tests on the 2.6.25.4 kernel, with >> a bunch of other patches needed for my system. >> >> Thanks a lot for your fast and good support for fixing this issue we >> had. > > You're welcome. Best regards Matthias Zacharias matthias.zacharias@xxxxxxxxxxxxxxxx -------------------- BMK electronic solutions GmbH Werner-von-Siemens-Str. 6, Eingang 18 f D-86159 Augsburg Tel. +49 (0) 821 / 207 88 - 700 Fax +49 (0) 821 / 207 88 - 721 info@xxxxxxxxxxxxxxxx GeschÃftsfÃhrer: Dipl.-oec. Alois KnÃferle Sitz: Augsburg HR-Nr.: B21197 --------------------- Diese E-mail kann vertrauliche Informationen enthalten. Falls Sie diese E-Mail irrtÃmlich erhalten haben, informieren Sie bitte unverzÃglich den Absender und lÃschen Sie diese E-Mail von jedem Rechner, auch von den Mailservern. Jede Verbreitung des Inhalts, auch die teilweise Verbreitung, ist in diesem Fall untersagt. AuÃer bei Vorsatz oder grober FahrlÃssigkeit schliessen wir jegliche Haftung fÃr Verluste oder SchÃden aus, die durch Viren befallene Software oder E-Mails verursacht werden. This e-mail may contain confidential information. If you received this e-mail in error, please contact the sender and delete this e-mail from your computer, including your mailservers. Any dissemination, even partly, is prohibited. Except in case of gross negligence or wilful misconduct we accept no liability for any loss or damage caused by software or e-mail viruses. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
