> While I agree that these parameters need documentation, I haven't seen > that there is an agreed upon place to put such documentation as of yet. > I followed your link but didn't find the corresponding document in the > kernel tree. Because it has not been applied yet; that was the "template" patch I could dig up fastest. > Should I really be putting my documentation in the > Documentation/powerpc directory? Not necessarily. You could post a patch moving the generic parts to a better location, too :) > > > +#ifdef CONFIG_OF > > > + i2c->adap.dev.of_node = pdev->dev.of_node; > > > +#endif > > > > No need for the ifdef here. > > > > Why? of_node is protected by CONFIG_OF in linux/device.h Ehrm, seems my mind broke :( Apologies, I probably was mixing it up with another issue. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
