On Wed, Nov 10, 2010 at 09:55:34AM +0900, Minkyu Kang wrote: > Dear Greg KH, > > On 12 October 2010 02:36, Greg KH <greg@xxxxxxxxx> wrote: > > On Mon, Oct 11, 2010 at 10:32:33AM +0900, Minkyu Kang wrote: > >> The FSA9480 is a USB port accessory detector and switch. > >> This patch adds support the FSA9480 USB Switch. > >> > >> Signed-off-by: Minkyu Kang <mk7.kang@xxxxxxxxxxx> > >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >> --- > >> v2: > >> ?use the threaded irq > >> ?fix the sysfs > >> > >> ?drivers/misc/Kconfig ? ?| ? ?9 + > >> ?drivers/misc/Makefile ? | ? ?1 + > >> ?drivers/misc/fsa9480.c ?| ?544 +++++++++++++++++++++++++++++++++++++++++++++++ > >> ?include/linux/fsa9480.h | ? 40 ++++ > > > > Why do you need a .h file here for a single driver? > > Because of platform data. Then put it in include/linux/platform_data/ instead please. > > You are creating new sysfs files, so you are required to add a new > > Documentation/ABI file as well, please add that to this patch. > > ok. > > > > > And why are you exporting symbols from this driver, that should not be > > needed at all. > > It's for other drivers. > For example.. When USB cable is connected, PMIC driver enable the > power for each device. (USB, uart, audio and so on..) > But if use the manual switch, PMIC driver can't know what device is enabled. > So, this function was exported. What drivers are using these functions? Where is the code for them? When will they be submitted for inclusion? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
