RE: [PATCH 1/1] Remove suspend/resume functionality, add dynamic clocking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> Subject: Re: [PATCH 1/1] Remove suspend/resume functionality, add dynamic
> clocking
> 
> Hello,
> 
> can you please add something like "i2c-pnx: " to the subject?
> (Actually it's a great strategy *not* to put it into the Subject.  This
> way it attracts far more attention :-)
> 

Good point!

> > Remove suspend/resume functionality, I2C driver gates clock on
> > only when an I2C transaction is in progress
> What happens when the machine suspends while a transfer is in progress?
> (This might be a problem that already existed before.)  If this is
> really a problem the easiest "fix" is to let the suspend callback return
> -EBUSY in this case.

The suspend callback is now removed. It's actually not needed with this
change. The I2C clocks will turn on prior to a transaction and then turn
off at the completion.

> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                              | Uwe Kleine-König
> |
> Industrial Linux Solutions                    | http://www.pengutronix.de/
> |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux