Ben Dooks wrote:
+ for_each_bit(i, &abort_source, ARRAY_SIZE(abort_sources)) + dev_err(dev->dev, "%s: %s\n", __func__, abort_sources[i]);Dev_err() might be annoying when we use sort of misc utilities such as i2c-tools. In case of no ACKs, we sometimes don't want to see error messages in the console, because such tools are sometimes capable of generating human-friendly console output like, root@localhost:/root> i2cdetect -y -r 2 0 1 2 3 4 5 6 7 8 9 a b c d e f 00: -- -- -- -- -- -- -- -- -- -- -- -- -- 10: -- -- -- -- -- -- -- -- ... root@localhost:/root> i2cdump -y 0 0x49 b 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef 00: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX 10: XX XX XX XX XX XX .... Then how do I change dev_err() here? I'm not sure dev_dbg() or other variants are acceptable for no ACKs or arbitration cases. Could someone give me a comment? I'll prepare patches for it.Maybe in the case of no-ack, this could be a debug message and erro for the case where you have an arbitration problem or other error that you wouldn't normally find on an I2C bus?
Thanks, I'll send an additional patch shortly. -- Shinya Kuribayashi NEC Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
