RE: [PATCH 1/2] i2c-bfin-twi: integrate timeout timer withcompletion interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yes, jiffies is used in this patch for timeout value.

Sonic 

-----Original Message-----
From: Wolfram Sang [mailto:w.sang@xxxxxxxxxxxxxx] 
Sent: Thursday, October 08, 2009 5:38 PM
To: Mike Frysinger
Cc: linux-i2c@xxxxxxxxxxxxxxx; Ben Dooks;
uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx; Zhang, Sonic
Subject: Re: [PATCH 1/2] i2c-bfin-twi: integrate timeout timer
withcompletion interface

On Wed, Oct 07, 2009 at 11:38:15PM -0400, Mike Frysinger wrote:
> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> 
> There isn't much point in managing our own custom timeout timer when 
> the completion interface already includes support for it.  This makes 
> the resulting code much simpler and robust.

This sounds like a good thing to do, but keep in mind that
adapter->timeout values should be in jiffies (see
8a52c6b4d55b2960d93a90a7cf6afd252357fa54).

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang
|
Industrial Linux Solutions                 | http://www.pengutronix.de/
|
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux