Re: [PATCH 1/2] i2c-bfin-twi: integrate timeout timer with completion interface

Wolfram Sang <w.sang@xxxxxxxxxxxxxx> · Thu, 8 Oct 2009 11:38:17 +0200

On Wed, Oct 07, 2009 at 11:38:15PM -0400, Mike Frysinger wrote:
> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> 
> There isn't much point in managing our own custom timeout timer when the
> completion interface already includes support for it.  This makes the
> resulting code much simpler and robust.

This sounds like a good thing to do, but keep in mind that adapter->timeout
values should be in jiffies (see 8a52c6b4d55b2960d93a90a7cf6afd252357fa54).

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Attachment:
signature.asc

Description: Digital signature