Re: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> [090803 17:23]:
> On Wed, Jul 29, 2009 at 10:06:13AM +0530, balajitk@xxxxxx wrote:
> 
> > -	if (twl_has_regulator()) {
> > +	if (twl_has_regulator() && is_class_twl4030()) {
> 
> is_class_twl4030() feels like it should have better namespacing, though
> having the part name in there means it's not actually an issue.

How about twl_is_4030()?
 
> > @@ -306,6 +306,7 @@ int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
> >  #define TWL4030_INT_PWR_EDR2		0x6
> >  #define TWL4030_INT_PWR_SIH_CTRL	0x7
> >  
> > +
> >  /*----------------------------------------------------------------------*/
> >  
> >  /* Power bus message definitions */
> 
> Random unrelated indentation change?
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux