> -----Original Message----- > From: Felipe Balbi [mailto:me@xxxxxxxxxxxxxxx] > Sent: Tuesday, July 21, 2009 10:55 AM > To: Shilimkar, Santosh > Cc: me@xxxxxxxxxxxxxxx; Krishnamoorthy, Balaji T; > linux-kernel@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; > khilman@xxxxxxxxxxxxxxxxxxx; david-b@xxxxxxxxxxx; > linux-omap@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; > sameo@xxxxxxxxxxxxxx; wim@xxxxxxxxx; > timo.t.kokkonen@xxxxxxxxx; ben-linux@xxxxxxxxx; > lrg@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx; > Nayak, Rajendra > Subject: Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver > files to enable re-use > > hi, > > On Tue, Jul 21, 2009 at 10:01:06AM +0530, Shilimkar, Santosh wrote: > > > So IMO, renaming the files is unnecessary. > > Well tps* are just catalog names of the twl4* family. So > you can keep adding whatever names there as long it's a same IC. > > > > Perhaps you look in hurry to comment about this. Please > look at the intention of these patches. TWL6030 has PM IC > similar to TWL4030 with bit different interrupt management. > Audio IC is a separate one as compared to combined in case of TWL4030. > > > > If it allows code re-use by renaming files, it should be > good. Isn't it ? > > What I'm trying to say is you can re-use the code even > without renaming > those files, just add twl6030-irq and use some sort of > runtime check to > use one or other irq mechanism. We initially tried this but code is becoming ugly and not at all readable. In fact this was a short cut and would have saved us some time :) By renaming, we thought it can become a generic for further versions of TWL IC's and adding support to those would be cleaner. Let's get feedback from more people on the list Regards, Santosh-- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
