On Mon, 29 Jun 2009 19:47:26 +0900, Minkyu Kang wrote: > Hi Jean, > > 2009/6/26 Jean Delvare <khali@xxxxxxxxxxxx>: > > On Fri, 26 Jun 2009 17:39:02 +0900, Minkyu Kang wrote: > >> The GP2A002 is a I2C interfaced Sensor for Proximity/Ambient > >> This patch adds support the GP2A002 sensor > >> > >> Signed-off-by: Minkyu Kang <mk7.kang@xxxxxxxxxxx> > >> Signed-off-by: Suchang Woo <suchang.woo@xxxxxxxxxxx> > >> --- > >> drivers/hwmon/Kconfig | 7 + > >> drivers/hwmon/Makefile | 1 + > >> drivers/hwmon/gp2ap002.c | 471 ++++++++++++++++++++++++++++++++++++++++++++++ > >> include/linux/gp2ap002.h | 21 ++ > >> 4 files changed, 500 insertions(+), 0 deletions(-) > >> create mode 100644 drivers/hwmon/gp2ap002.c > >> create mode 100644 include/linux/gp2ap002.h > >> > >> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > >> index 2d50166..cc4e200 100644 > >> --- a/drivers/hwmon/Kconfig > >> +++ b/drivers/hwmon/Kconfig > >> @@ -1017,6 +1017,13 @@ config SENSORS_APPLESMC > >> Say Y here if you have an applicable laptop and want to experience > >> the awesome power of applesmc. > >> > >> +config SENSORS_GP2AP002 > >> + tristate "GP2AP002 series Proximity/Ambient Sensor" > >> + depends on HWMON && I2C > >> + help > >> + This driver provides support for Proximity/Ambient Sensor. > >> + > > > > This doesn't have anything to do with hardware monitoring, so this > > doesn't belong to drivers/hwmon. > > > > Can you please explain about belong to hardware monitoring? > did i missing something? I'm not sure how I can explain it better. Your driver is for a device which is no a hardware monitoring chip, so this driver should not be located in the drivers/hwmon directory. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
