On Mon, 8 Jun 2009 23:50:34 +0100, Ben Dooks wrote: > On Wed, Jun 03, 2009 at 11:59:15PM +0400, dmitry pervushin wrote: > > +static const u32 I2C_READ = 1, > > + I2C_WRITE = 0; > > do you really want to be defining things with a prefix of I2C, that > might end up clashing with the i2c core? Definitely not. Please just use I2C_SMBUS_READ and I2C_SMBUS_WRITE which are already defined by <linux/i2c.h>. (One might argue these are unfortunate names, but that's what we have at the moment so let's just use it.) -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
