Hi, Trilok > Adding linux-i2c mailing list, so not deleting any code. Ok, I will. >> +static struct max17040_chip *max17040; >> +static struct max17040_platform_data *pdata; > > May be you want to move this pdata under chip structure. > >> + i2c_set_clientdata(client, chip); > > Please add i2c_check_functionality check before doing any smbus > read/write operations. > Ok, that's better. >> + max17040 = chip; > > This means that we support only one instance of this chip, right? > Yes right.. but, I think that is not a good way. I'll modify it, too. thanks :) -- from. prom. promsoft.net -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
