Re: [PATCH] I2C:Moving Register Defines to Header File

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Syed Rafiuddin" <rafiuddin.syed@xxxxxx> writes:

>> "Syed Rafiuddin" <rafiuddin.syed@xxxxxx> writes:
>>
>>> This patch creates i2c-omap.h header and moves register and bit definition
>>> macros to it from i2c-omap.c
>>
>> Please use the description to describe the motivation for the changes
>> and the problems it is addressing/fixing.
>>
>> In other words, you described what your patch does but not why.
>
> The intention of the patch is to have a separate header which will have omap3
> and omap4 related register definitions. As omap4 has different offset addresses
> with respect to omap3,adding omap4 related stuff in the same file will leave
> the file look ugly.

IMO, The regs do not need to move to a separate header unless they will
be used outside of i2c-omap.c.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux