On 12/21/24 08:48, David Laight wrote: > On Sat, 21 Dec 2024 07:57:10 -0800 > Dave Hansen <dave.hansen@xxxxxxxxx> wrote: > >> On 12/21/24 02:35, David Laight wrote: >>>> #define INTEL_PENTIUM_PRO IFM(6, 0x01) >>>> +#define INTEL_PENTIUM_II_KLAMATH IFM(6, 0x03) >>>> +#define INTEL_PENTIUM_III_TUALATIN IFM(6, 0x0B) >>>> +#define INTEL_PENTIUM_M_DOTHAN IFM(6, 0x0D) >>>> >>>> #define INTEL_CORE_YONAH IFM(6, 0x0E) >>> I think I'd add all the extra defines in one patch. >> I actually prefer them being with their first user. That way, if patches >> get dropped or moved, nothing can be in the wrong order or unnecessary. > Does 'unnecessary' matter. > It isn't as though there are hundreds of them. It matters to me. I'll let Sohil make the decision if he want to follow your preferences or mine.
