On 12/21/24 02:35, David Laight wrote: >> #define INTEL_PENTIUM_PRO IFM(6, 0x01) >> +#define INTEL_PENTIUM_II_KLAMATH IFM(6, 0x03) >> +#define INTEL_PENTIUM_III_TUALATIN IFM(6, 0x0B) >> +#define INTEL_PENTIUM_M_DOTHAN IFM(6, 0x0D) >> >> #define INTEL_CORE_YONAH IFM(6, 0x0E) > > I think I'd add all the extra defines in one patch. I actually prefer them being with their first user. That way, if patches get dropped or moved, nothing can be in the wrong order or unnecessary. > Isn't the order 'funny' as well. > I think it ends up being neither numeric or date order. > Increasing family order is probably best, but the headings for each > 'family' probably need to be a bit more descriptive (esp 15 - all P4 > netburst). <shrug> They're already out of order because Quark is a weirdo and we didn't want to look at it all the time so it got stuck at the bottom. It's _fine_ when it's 99% family 6 plus 2 other weirdos. But it should probably get sorted at some point because it's going to be hard to find Quark and P4 if the order is fam 6,1 fam 5 fam 15 fam 18 fam 19 fam 20 ... But I think all that has to be done is to move Quark up to the top.
