On Thu, Mar 31, 2022 at 04:51:47PM +0200, Michael Walle wrote: > Am 2022-03-31 16:45, schrieb Russell King (Oracle): > > On Wed, Mar 30, 2022 at 08:23:35AM -0700, Guenter Roeck wrote: > > > Michael, let's just drop the changes outside drivers/hwmon from > > > the series, and let's keep hwmon_is_bad_char() in the include file. > > > Let's just document it, explaining its use case. > > > > Why? There hasn't been any objection to the change. All the discussion > > seems to be around the new function (this patch) rather than the actual > > conversions in drivers. > > > > I'm entirely in favour of cleaning this up - it irks me that we're doing > > exactly the same cleanup everywhere we have a hwmon. > > > > At the very least, I would be completely in favour of keeping the > > changes in the sfp and phy code. > > FWIW, my plan was to send the hwmon patches first, by then my other > series (the polynomial_calc() one) will also be ready to be picked. > Then I'd ask Guenter for a stable branch with these two series which > hopefully get merged into net-next. Then I can repost the missing > patches on net-next along with the new sensors support for the GPY > and LAN8814 PHYs. Okay, that's fine. It just sounded like the conversion of other drivers outside drivers/hwmon was being dropped. Note that there's another "sanitisation" of hwmon names in drivers/net/phy/marvell.c - that converts any non-alnum character to an underscore. Not sure why the different approach was chosen there. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
