On Wed, Mar 30, 2022 at 08:23:35AM -0700, Guenter Roeck wrote: > Michael, let's just drop the changes outside drivers/hwmon from > the series, and let's keep hwmon_is_bad_char() in the include file. > Let's just document it, explaining its use case. Why? There hasn't been any objection to the change. All the discussion seems to be around the new function (this patch) rather than the actual conversions in drivers. I'm entirely in favour of cleaning this up - it irks me that we're doing exactly the same cleanup everywhere we have a hwmon. At the very least, I would be completely in favour of keeping the changes in the sfp and phy code. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
