Am 2022-03-31 16:45, schrieb Russell King (Oracle):
On Wed, Mar 30, 2022 at 08:23:35AM -0700, Guenter Roeck wrote:
Michael, let's just drop the changes outside drivers/hwmon from
the series, and let's keep hwmon_is_bad_char() in the include file.
Let's just document it, explaining its use case.
Why? There hasn't been any objection to the change. All the discussion
seems to be around the new function (this patch) rather than the actual
conversions in drivers.
I'm entirely in favour of cleaning this up - it irks me that we're
doing
exactly the same cleanup everywhere we have a hwmon.
At the very least, I would be completely in favour of keeping the
changes in the sfp and phy code.
FWIW, my plan was to send the hwmon patches first, by then my other
series (the polynomial_calc() one) will also be ready to be picked.
Then I'd ask Guenter for a stable branch with these two series which
hopefully get merged into net-next. Then I can repost the missing
patches on net-next along with the new sensors support for the GPY
and LAN8814 PHYs.
For the last patch, if it should be applied or not, or when, that
will be up to Guenter then.
-michael
