Re: [PATCH] nvme-hwmon: drop not common HWMON_T_MIN and HWMON_T_MAX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/14/21 8:51 AM, Wang Yugui wrote:
[ ...]
> 
> Most of the users do not like something like 'low  = -273.1°C' or 
> 'high = +65261.8°C' that just seem noise, or software bug, or hardware
> error, and that will cause unnecessary worry.
> 
> We can support more HWMON_T_MIN and HWMON_T_MAX for advanced 
> user iff a valid configure value in the futher, and without any noise.
> 

This is not a valid argument. This is similar for almost all
sensors. You are effectively arguing that all limits for all sensors
should be disabled unless a default is configured by the hardware.
For example, looking at the Super-IO chip output in one of my systems,
I see:

nct6797-isa-0a20
Adapter: ISA adapter
in0:                    +1.42 V  (min =  +0.00 V, max =  +1.74 V)
in1:                    +1.02 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in2:                    +3.39 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in3:                    +3.31 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in4:                    +0.99 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in5:                    +0.15 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in6:                    +0.55 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in7:                    +3.39 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in8:                    +3.28 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in9:                    +1.82 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in10:                   +0.00 V  (min =  +0.00 V, max =  +0.00 V)
in11:                   +0.66 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in12:                   +1.21 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in13:                   +0.68 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in14:                   +1.50 V  (min =  +0.00 V, max =  +0.00 V)  ALARM

Following your line of argument, we should disable reporting (and setting)
minimum and maximum values for pretty much all hardware monitoring drivers
because the hardware (or the BIOS) doesn't set default values. This simply
does not make any sense at all.

If you don't like the default limit output, I would suggest to either
configure limits or to disable the driver in your system. Depriving
all other users from setting limits (and getting alarms if they are
exceeded) just because you don't like that the hardware does not
initialize those limits is an exceedingly bad idea.

Thanks,
Guenter



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux