Hi, > On 3/13/21 2:44 PM, Wang Yugui wrote: > > Hi, > > > >> On 3/13/21 12:32 AM, wangyugui wrote: > >>> HWMON_T_MIN is not common in NVMe SSD, so drop all of them in nvme-hwmon. > >>> > >>> HWMON_T_MAX is only common in NVMe SSD Composite sensor, so drop them in other sensors. > >>> > >>> Before this patch(SSD: PM1733): > >>> #sensors > >>> nvme-pci-4300 > >>> Adapter: PCI adapter > >>> Composite: +49.9°C (low = -273.1°C, high = +71.8°C) > >>> (crit = +84.8°C) > >>> Sensor 1: +47.9°C (low = -273.1°C, high = +65261.8°C) > >>> ERROR: Can't get value of subfeature temp3_min: I/O error > >>> ERROR: Can't get value of subfeature temp3_max: I/O error > >>> Sensor 2: +49.9°C (low = +0.0°C, high = +0.0°C) > >>> > >>> # cat /sys/class/nvme/nvme0/hwmon1/temp3_min > >>> cat: /sys/class/nvme/nvme0/hwmon1/temp3_min: Input/output error > >>> # cat /sys/class/nvme/nvme0/hwmon1/temp3_max > >>> cat: /sys/class/nvme/nvme0/hwmon1/temp3_max: Input/output error > >>> > >>> After this patch(SSD: PM1733): > >>> #sensors > >>> nvme-pci-4300 > >>> Adapter: PCI adapter > >>> Composite: +48.9°C (high = +71.8°C, crit = +84.8°C) > >>> Sensor 1: +46.9°C > >>> Sensor 2: +48.9°C > >>> > >> > >> Signed-off-by: missing. > >> > >> Either case, no. > >> > >> On one of my NVMEs, after setting the limits: > >> > >> nvme-pci-0100 > >> Adapter: PCI adapter > >> Composite: +29.9°C (low = -0.1°C, high = +76.8°C) > >> (crit = +78.8°C) > >> Sensor 1: +29.9°C (low = -0.1°C, high = +254.8°C) > >> Sensor 2: +37.9°C (low = -0.1°C, high = +254.8°C) > > > > high = +254.8°C is a real value or unconfigured value ? > > > > This was a configured value, as mentioned above. Same system and NVME, > with differently configured limit values: > > nvme-pci-0100 > Adapter: PCI adapter > Composite: +31.9°C (low = -0.1°C, high = +76.8°C) > (crit = +78.8°C) > Sensor 1: +31.9°C (low = -10.2°C, high = +126.8°C) > Sensor 2: +49.9°C (low = +4.8°C, high = +89.8°C) > > Default values, with a different NVME, on a different system: > > nvme-pci-0100 > Adapter: PCI adapter > Composite: +38.9°C (low = -273.1°C, high = +84.8°C) > (crit = +84.8°C) > Sensor 1: +38.9°C (low = -273.1°C, high = +65261.8°C) > Sensor 2: +42.9°C (low = -273.1°C, high = +65261.8°C) > > Same NVME as the first one, in a different system, with default > values: > > nvme-pci-2500 > Adapter: PCI adapter > Composite: +38.9°C (low = -273.1°C, high = +76.8°C) > (crit = +78.8°C) > Sensor 1: +38.9°C (low = -273.1°C, high = +65261.8°C) > Sensor 2: +44.9°C (low = -273.1°C, high = +65261.8°C) > > Guenter Most of the users do not like something like 'low = -273.1°C' or 'high = +65261.8°C' that just seem noise, or software bug, or hardware error, and that will cause unnecessary worry. We can support more HWMON_T_MIN and HWMON_T_MAX for advanced user iff a valid configure value in the futher, and without any noise. Best Regards Wang Yugui (wangyugui@xxxxxxxxxxxx) 2021/03/14
