On 1/21/19 7:28 AM, Sudeep Holla wrote:
On Mon, Jan 21, 2019 at 07:22:44AM -0800, Guenter Roeck wrote:
On 1/21/19 1:38 AM, Sudeep Holla wrote:
[...]
Sorry for not being clear, I was referring to these:
$ git grep "return S_.*" drivers/hwmon/ | sort | uniq
[...]
drivers/hwmon/tmp102.c: return S_IRUGO;
drivers/hwmon/tmp102.c: return S_IRUGO | S_IWUSR;
drivers/hwmon/tmp421.c: return S_IRUGO;
The series only includes auto-converted drivers, and the conversion
focused on auto-converting SENSOR_ attributes. While it tried to convert
various instances of the above, that was not the primary focus. I will
likely submit one or more follow-up series to address remaining
SENSOR_... attributes as well as any leftover S_<perms> definitions.
OK sounds good, just wanted to make sure I understood the intention
for this right.
After having another look ... did you check the entire series
of patches ? Because for me, in hwmon-next:
$ git grep "return S_.*" drivers/hwmon/ | sort | uniq
$
Guenter
