Re: [PATCH 29/30] hwmon: (vexpress-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 21, 2019 at 07:22:44AM -0800, Guenter Roeck wrote:
> On 1/21/19 1:38 AM, Sudeep Holla wrote:

[...]

> > Sorry for not being clear, I was referring to these:
> > $ git grep "return S_.*" drivers/hwmon/ | sort | uniq
> >

[...]

> > drivers/hwmon/tmp102.c:		return S_IRUGO;
> > drivers/hwmon/tmp102.c:		return S_IRUGO | S_IWUSR;
> > drivers/hwmon/tmp421.c:		return S_IRUGO;
> >
>
> The series only includes auto-converted drivers, and the conversion
> focused on auto-converting SENSOR_ attributes. While it tried to convert
> various instances of the above, that was not the primary focus. I will
> likely submit one or more follow-up series to address remaining
> SENSOR_... attributes as well as any leftover S_<perms> definitions.
>

OK sounds good, just wanted to make sure I understood the intention
for this right.

--
Regards,
Sudeep



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux