On Fri, Jan 18, 2019 at 06:21:57PM +0000, Sudeep Holla wrote:
> On Fri, Jan 18, 2019 at 09:14:59AM -0800, Guenter Roeck wrote:
> > Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
> > to improve readbility, and to reduce the chance of inconsistencies.
> >
>
> s/readbility/readability/
>
Nice catch ...
> > Also replace any remaining S_<PERMS> in the driver with octal values.
> >
> > The conversion was done automatically with coccinelle. The semantic patches
> > and the scripts used to generate this commit log are available at
> > https://github.com/groeck/coccinelle-patches/hwmon/.
> >
> > This patch does not introduce functional changes. It was verified by
> > compiling the old and new files and comparing text and data sizes.
> >
> > Cc: Liviu Dudau <liviu.dudau@xxxxxxx>
> > Cc: Sudeep Holla <sudeep.holla@xxxxxxx>
>
> Not related to this patch, just thought of asking. If the intention is
> to avoid using S_<PERMS> macros and have direct values for readability,
> shouldn't you consider the ones as return values mainly in is_visible
> callbacks ?
>
Not sure I understand. Can you clarify ?
Thanks,
Guenter
> Anyways,
>
> Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>
>
> --
> Regards,
> Sudeep
