Hello, ... > > And this is precisely the kind of information that needs to go into > > commit messages. I can tell *what* you're doing by looking at the > > code. What I can't tell is *why*. > > +1. Please, add this to the commit message of v2, also try to find the commit > that you can mark to be fixed with help of Fixes tag. Thanks for suggestion regarding Fixes! I thought maybe I should as well move whole GPIO initialization[0] down to the same place I move "gpiod_set_value_cansleep( chip->gpiod_oe, 1)" in patch v2? I think knowledge that a pin is brought up later during probing process might be forgotten later, it will slightly complicate code due to need to clean mutex though. [0] https://elixir.bootlin.com/linux/v6.7.6/source/drivers/gpio/gpio-74x164.c#L125 Arturas Moskvinas