Re: [PATCH -next v3] gpio: xra1403: remove redundant of_match_ptr()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Aug 3, 2023 at 4:13 AM Zhu Wang <wangzhu9@xxxxxxxxxx> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here, and __maybe_unused can also be removed.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.
>
> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> ---
> Changes in v2:
> - Change of_match_ptr to of_match_ptr() in the commit message.
> - Drop mod_devicetable.h.
>
> ---
> Changes in v3:
> - Include mod_devicetable.h.
> ---
>  drivers/gpio/gpio-xra1403.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c
> index eed8a1684830..dc2710c21c50 100644
> --- a/drivers/gpio/gpio-xra1403.c
> +++ b/drivers/gpio/gpio-xra1403.c
> @@ -194,7 +194,7 @@ static const struct spi_device_id xra1403_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(spi, xra1403_ids);
>
> -static const struct of_device_id xra1403_spi_of_match[] __maybe_unused = {
> +static const struct of_device_id xra1403_spi_of_match[] = {
>         { .compatible = "exar,xra1403" },
>         {},
>  };
> @@ -205,7 +205,7 @@ static struct spi_driver xra1403_driver = {
>         .id_table = xra1403_ids,
>         .driver   = {
>                 .name           = "xra1403",
> -               .of_match_table = of_match_ptr(xra1403_spi_of_match),
> +               .of_match_table = xra1403_spi_of_match,
>         },
>  };
>
> --
> 2.17.1
>

Applied, thanks!

Bart