Re: [PATCH -next v3] gpio: max732x: remove redundant CONFIG_OF and of_match_ptr()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Aug 3, 2023 at 4:21 AM Zhu Wang <wangzhu9@xxxxxxxxxx> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here. We remove both CONFIG_OF and of_match_ptr() here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.
>
> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> ---
> Changes in v2:
> - Change of_match_ptr to of_match_ptr() in the commit message.
> - Drop of.h which is not needed anymore.
>
> ---
> Changes in v3:
> - Drop the extra blank line below the #include statement.
> ---
>  drivers/gpio/gpio-max732x.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c
> index fca9ca68e387..49d362907bc7 100644
> --- a/drivers/gpio/gpio-max732x.c
> +++ b/drivers/gpio/gpio-max732x.c
> @@ -18,8 +18,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/i2c.h>
>  #include <linux/platform_data/max732x.h>
> -#include <linux/of.h>
> -
>
>  /*
>   * Each port of MAX732x (including MAX7319) falls into one of the
> @@ -114,7 +112,6 @@ static const struct i2c_device_id max732x_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, max732x_id);
>
> -#ifdef CONFIG_OF
>  static const struct of_device_id max732x_of_table[] = {
>         { .compatible = "maxim,max7319" },
>         { .compatible = "maxim,max7320" },
> @@ -128,7 +125,6 @@ static const struct of_device_id max732x_of_table[] = {
>         { }
>  };
>  MODULE_DEVICE_TABLE(of, max732x_of_table);
> -#endif
>
>  struct max732x_chip {
>         struct gpio_chip gpio_chip;
> @@ -709,7 +705,7 @@ static int max732x_probe(struct i2c_client *client)
>  static struct i2c_driver max732x_driver = {
>         .driver = {
>                 .name           = "max732x",
> -               .of_match_table = of_match_ptr(max732x_of_table),
> +               .of_match_table = max732x_of_table,
>         },
>         .probe          = max732x_probe,
>         .id_table       = max732x_id,
> --
> 2.17.1
>

Applied, thanks!

Bart