Re: [PATCH -next v3] gpio: tps65218: remove redundant of_match_ptr()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Aug 3, 2023 at 4:29 AM Zhu Wang <wangzhu9@xxxxxxxxxx> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr().
>
> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> ---
> Changes in v2:
> - Change of_match_ptr to of_match_ptr() in the commit message.
>
> ---
> Changes in v3:
> - Add a trailing comma after tps65218_dt_match.
> ---
>  drivers/gpio/gpio-tps65218.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
> index e1d425a18854..d7d9d50dcddf 100644
> --- a/drivers/gpio/gpio-tps65218.c
> +++ b/drivers/gpio/gpio-tps65218.c
> @@ -216,7 +216,7 @@ MODULE_DEVICE_TABLE(platform, tps65218_gpio_id_table);
>  static struct platform_driver tps65218_gpio_driver = {
>         .driver = {
>                 .name = "tps65218-gpio",
> -               .of_match_table = of_match_ptr(tps65218_dt_match)
> +               .of_match_table = tps65218_dt_match,
>         },
>         .probe = tps65218_gpio_probe,
>         .id_table = tps65218_gpio_id_table,
> --
> 2.17.1
>

Applied, thanks!

Bart