Re: [PATCH -next RESEND] gpio: ftgpio010: Do not check for 0 return after calling platform_get_irq()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Aug 3, 2023 at 5:40 AM Ruan Jinjie <ruanjinjie@xxxxxxxxxx> wrote:
>
> Since commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0
> is invalid"), there is no possible for platform_get_irq() to return 0.
>
> And the return value of platform_get_irq() is more sensible
> to show the error reason.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-ftgpio010.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
> index 31e26072f6ae..5ce59dcf02e3 100644
> --- a/drivers/gpio/gpio-ftgpio010.c
> +++ b/drivers/gpio/gpio-ftgpio010.c
> @@ -250,8 +250,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
>                 return PTR_ERR(g->base);
>
>         irq = platform_get_irq(pdev, 0);
> -       if (irq <= 0)
> -               return irq ? irq : -EINVAL;
> +       if (irq < 0)
> +               return irq;
>
>         g->clk = devm_clk_get(dev, NULL);
>         if (!IS_ERR(g->clk)) {
> --
> 2.34.1
>

Applied, thanks!

Bart